-
Notifications
You must be signed in to change notification settings - Fork 55
Add tests for Test Result Visualization #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Do we have any test coverage for the summary showing up if the user uses runMATLABTests
?
@Test | ||
public void verifyTestResultsSummary() throws Exception { | ||
FreeStyleProject project = jenkins.createFreeStyleProject(); | ||
project.setScm(new ExtractResourceSCM(Utilities.getRunMATLABTestsData())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the existing system test utilities right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 'Utilities' is mainly used for system tests. I updated the method name to 'getURLForTestData' as it is more apt.
src/test/java/com/mathworks/ci/systemtests/TestResultVisualizationIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemtests/TestResultVisualizationIT.java
Outdated
Show resolved
Hide resolved
|
||
Combination c = new Combination(new AxisList(new MatlabInstallationAxis(Arrays.asList("MATLAB_PATH_1"))), "MATLAB_PATH_1"); | ||
MatrixRun run = build.getRun(c); | ||
String[] buildResultSummary= getTestResultSummaryFromBuildStatusPage(run); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String[] buildResultSummary= getTestResultSummaryFromBuildStatusPage(run); | |
String[] buildResultSummaries = getTestResultSummaryFromBuildStatusPage(run); |
src/test/java/com/mathworks/ci/systemtests/TestResultVisualizationIT.java
Outdated
Show resolved
Hide resolved
Run MATLAB Tests is not supported yet. Once those source changes are in, I will add the tests for that. |
I have raised another PR under jenkinsci/matlab-plugin repo for same changes. Closing this PR, review can be continued from new PR. |
Adding system tests for Test Result Visualization