Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Add tests for Test Result Visualization #427

Closed
wants to merge 3 commits into from
Closed

Conversation

Vahila
Copy link
Member

@Vahila Vahila commented Mar 17, 2025

Adding system tests for Test Result Visualization

Copy link
Member

@sameagen-MW sameagen-MW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we have any test coverage for the summary showing up if the user uses runMATLABTests?

@Test
public void verifyTestResultsSummary() throws Exception {
FreeStyleProject project = jenkins.createFreeStyleProject();
project.setScm(new ExtractResourceSCM(Utilities.getRunMATLABTestsData()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the existing system test utilities right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 'Utilities' is mainly used for system tests. I updated the method name to 'getURLForTestData' as it is more apt.


Combination c = new Combination(new AxisList(new MatlabInstallationAxis(Arrays.asList("MATLAB_PATH_1"))), "MATLAB_PATH_1");
MatrixRun run = build.getRun(c);
String[] buildResultSummary= getTestResultSummaryFromBuildStatusPage(run);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String[] buildResultSummary= getTestResultSummaryFromBuildStatusPage(run);
String[] buildResultSummaries = getTestResultSummaryFromBuildStatusPage(run);

@Vahila
Copy link
Member Author

Vahila commented Mar 18, 2025

Looks good! Do we have any test coverage for the summary showing up if the user uses runMATLABTests?

Run MATLAB Tests is not supported yet. Once those source changes are in, I will add the tests for that.

@Vahila Vahila requested a review from sameagen-MW March 20, 2025 03:32
@Vahila
Copy link
Member Author

Vahila commented Mar 20, 2025

I have raised another PR under jenkinsci/matlab-plugin repo for same changes. Closing this PR, review can be continued from new PR.

@Vahila Vahila closed this Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants