Skip to content

Update versions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Update versions #7

merged 7 commits into from
Apr 11, 2024

Conversation

davidbuzinski
Copy link
Member

No description provided.

@mw-hrastega
Copy link
Member

_ No description provided. _

Should README.md also be part of this pull request?

@davidbuzinski
Copy link
Member Author

_ No description provided. _

Should README.md also be part of this pull request?

Yes, it's included. I just updated the versions in the examples.

inputs:
sourceFolder: source
codeCoverageCobertura: coverage.xml
- script: bash <(curl -s https://codecov.io/bash)
- script: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code was terse. This replacement is quite verbose and hard to understand. Can I know why we had to make this replacement?

Copy link
Member Author

@davidbuzinski davidbuzinski Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the bash script is still available, but they are moving towards using their CLI going forward. When you setup a new project on codecov.io and choose "Other CI" (Not GitHub Actions or CircleCI) they recommend doing things this way
Screenshot 2024-04-02 at 11 10 25 AM
mend this code:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks for clarifying, David.

@mw-hrastega
Copy link
Member

_ No description provided. _

Should README.md also be part of this pull request?

Yes, it's included. I just updated the versions in the examples.

Ok, I think some text also needs to be updated:

  1. You wanted to discontinue support for Travis CI. Does it still make sense to have it on the page?
  2. The Caveats section is outdated.

@mw-hrastega mw-hrastega self-requested a review April 2, 2024 14:11
@davidbuzinski
Copy link
Member Author

_ No description provided. _

Should README.md also be part of this pull request?

Yes, it's included. I just updated the versions in the examples.

Ok, I think some text also needs to be updated:

1. You wanted to discontinue support for Travis CI. Does it still make sense to have it on the page?

2. The Caveats section is outdated.

Good idea. I removed the Travis example and caveats section.

@davidbuzinski davidbuzinski merged commit 40d9175 into main Apr 11, 2024
1 check passed
@davidbuzinski davidbuzinski deleted the update-versions branch April 11, 2024 14:16
thomasrockhu-codecov added a commit to codecov/matlab-codecov-example that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants