Upstream merge v1.14.11 #1452
Open
Upstream merge v1.14.11 #1452
+131
−426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#30512) This is for fixing Prysm integration tests.
Use types.Sender(signer, tx) to utilize the transaction's sender cache and avoid repeated address recover.
This PR removes the dependencies on `lightchaindata` db as the light protocol has been deprecated and removed from the codebase.
Release 1.14.11
The results for the commit interrupt tests via new transactions channel were non-deterministic and used to fail sometimes. This was because we use `w.current` to calculate the delay which needs to be correct for the test to work as expected. It takes a while before `w.current` is updated to the next block (block 3 in this case). This PR adds a small delay so that we have the new block and delays are accurately calculated for the test to work.
* use matic-cli docker scripts * revert scripts for cp issue * change dir for int tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge Makhaira (v1.14.11) from upstream.
One of the major change is the removal of total difficulty field from the block schema (external facing i.e. rpc one).
Evaluate the removal of this field before merging this PR. Also, notify before the release to external operators so that they're prepared as it can affect downstream applications, indexers and block explorers.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it