Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker scripts in matic-cli #1453

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Docker scripts in matic-cli #1453

merged 3 commits into from
Feb 18, 2025

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Feb 18, 2025

Description

Update docker scripts in matic-cli for CI tests.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (6947088) to head (40e4802).
Report is 243 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1453      +/-   ##
===========================================
+ Coverage    50.30%   50.56%   +0.25%     
===========================================
  Files          769      760       -9     
  Lines       125643   122744    -2899     
===========================================
- Hits         63209    62067    -1142     
+ Misses       58398    56761    -1637     
+ Partials      4036     3916     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit f4f30d9 into develop Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants