Prevent TestResultsSummaryPlugin from throwing jsonencode related errors - #10
Conversation
|
So essentially, with this fix we are adding a try–catch block to handle cases where jsonencode throws an error, correct? In those situations, what do users currently experience—do they simply not get any test summary view? |
|
Can you verify that this solution works for the two use cases from the customer escalations? |
sameagen-MW
left a comment
There was a problem hiding this comment.
Same feedback as the other PR. Seems like a reasonable short term fix to me.
That's correct and, in those situations, the user won't see any view.
I was able to reproduce one of the two user issues and can confirm the fix was working fine. For the other issue, the user couldn't share any of their files (even smaller reproducible version) due to IP issues so can't reproduce the exact use case. |
@mw-kapilg - What happens when a test suite contains a mix of MATLAB and Simulink tests? Users were previously able to view the results, but after adding several additional mldatx‑based tests, they now encounter this exception. |
For a test suite containing both MATLAB and Simulink tests, the plugin should work fine. If the users were able to previously view the results, they'll continue to see them even after this change. If the suite contains a SL test that involves an edge case scenario which results in an exception, the test results view won't be shown at all (not even for other MATLAB and non-erroring SL tests). |
Fixes matlab-actions/run-tests#74
This change is only a short term patch; a long term solution will be submitted soon.