Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v6
- uses: matlab-actions/setup-matlab@v3
with:
release: latest-including-prerelease
release: latest
- uses: matlab-actions/run-tests@v3
with:
source-folder: plugins
Expand Down
10 changes: 4 additions & 6 deletions src/buildSummary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ import * as core from "@actions/core";
import { join } from "path";
import { readFileSync, unlinkSync, existsSync } from "fs";

export function addSummary(taskSummaryTableRows: string[][], actionName: string) {
export function addSummary(taskSummaryTableRows: string[][]) {
try {
core.summary
.addHeading("MATLAB Build Results (" + actionName + ") ")
.addTable(taskSummaryTableRows);
core.summary.addHeading("MATLAB Build Results").addTable(taskSummaryTableRows);
} catch (e) {
console.error("An error occurred while adding the build results table to the summary:", e);
}
Expand Down Expand Up @@ -45,7 +43,7 @@ export function interpretSkipReason(skipReason: string) {
}
}

export function processAndAddBuildSummary(runnerTemp: string, runId: string, actionName: string) {
export function processAndAddBuildSummary(runnerTemp: string, runId: string) {
const header = [
{ data: "MATLAB Task", header: true },
{ data: "Status", header: true },
Expand Down Expand Up @@ -73,6 +71,6 @@ export function processAndAddBuildSummary(runnerTemp: string, runId: string, act
);
}
}
addSummary(taskSummaryTable, actionName);
addSummary(taskSummaryTable);
}
}
6 changes: 2 additions & 4 deletions src/buildSummary.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,12 @@ describe("summaryGeneration", () => {
["MATLAB Task", "Status", "Description", "Duration (HH:mm:ss)"],
["Test Task", "🔴 Failed", "A test task", "00:00:10"],
];
const actionName = "run-build";

buildSummary.addSummary(mockTableRows, actionName);
buildSummary.addSummary(mockTableRows);

expect(core.summary.addHeading).toHaveBeenCalledTimes(1);
expect(core.summary.addHeading).toHaveBeenNthCalledWith(
1,
expect.stringContaining("MATLAB Build Results (" + actionName + ")"),
expect.stringContaining("MATLAB Build Results"),
);
expect(core.summary.addTable).toHaveBeenCalledTimes(1);
expect(core.summary.addTable).toHaveBeenCalledWith(mockTableRows);
Expand Down
14 changes: 3 additions & 11 deletions src/testResultsSummary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,11 @@ export interface TestResultsData {
Stats: TestStatistics;
}

export function processAndAddTestSummary(
runnerTemp: string,
runId: string,
actionName: string,
workspace: string,
) {
export function processAndAddTestSummary(runnerTemp: string, runId: string, workspace: string) {
const testResultsData = getTestResults(runnerTemp, runId, workspace);
const coverageResultsData = getCoverageResults(runnerTemp, runId);
if (testResultsData || coverageResultsData) {
addSummary(testResultsData, coverageResultsData, actionName);
addSummary(testResultsData, coverageResultsData);
}
}

Expand Down Expand Up @@ -137,7 +132,6 @@ export function getTestResults(
export function addSummary(
testResultsData: TestResultsData | null,
coverageResultsData: CoverageData | null,
actionName: string,
) {
try {
// Add test results table if available
Expand All @@ -147,9 +141,7 @@ export function addSummary(
` target="_blank" title="View documentation">ℹ️</a>`;
const header = getTestHeader(testResultsData.Stats);

core.summary
.addHeading("MATLAB Test Results (" + actionName + ") " + helpLink)
.addRaw(header, true);
core.summary.addHeading("MATLAB Test Results " + helpLink).addRaw(header, true);
}
// Add coverage table if available
if (coverageResultsData) {
Expand Down
6 changes: 3 additions & 3 deletions src/testResultsSummary.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,12 @@ describe("Artifact Processing Tests", () => {
it("should write test results data to the GitHub job summary", () => {
if (testResultsData) {
const actionName = process.env.GITHUB_ACTION || "";
testResultsSummary.addSummary(testResultsData, null, actionName);
testResultsSummary.addSummary(testResultsData, null);

expect(core.summary.addHeading).toHaveBeenCalledTimes(2);
expect(core.summary.addHeading).toHaveBeenNthCalledWith(
1,
expect.stringContaining("MATLAB Test Results (" + actionName + ")"),
expect.stringContaining("MATLAB Test Results "),
);
expect(core.summary.addHeading).toHaveBeenNthCalledWith(
1,
Expand Down Expand Up @@ -355,7 +355,7 @@ describe("Error Handling Tests", () => {

// This should not throw, but should log the error
expect(() => {
testResultsSummary.addSummary(mockTestResultsData, null, "mockAction");
testResultsSummary.addSummary(mockTestResultsData, null);
}).not.toThrow();

// Verify error was logged
Expand Down
3 changes: 2 additions & 1 deletion tests/tParallelizableBuildSummaryPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
function setupPath(testCase)
import matlab.unittest.fixtures.PathFixture;

testCase.assumeFalse(isMATLABReleaseOlderThan("R2026a"));
testCase.applyFixture(PathFixture(fileparts(fileparts(mfilename("fullpath")))));
end
end
Expand Down Expand Up @@ -107,4 +108,4 @@ function runningBuildCreatesSummaryForTaskGroups(testCase)

function task = Task(varargin)
task = matlab.buildtool.Task(varargin{:});
end
end
Loading