Skip to content

Update ParallelizableBuildSummaryPlugin.m to fix Windows filepath issue. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sameagen-MW merged 9 commits into from
Mar 12, 2026
Merged

Update ParallelizableBuildSummaryPlugin.m to fix Windows filepath issue. #3

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d26284
Update ParallelizableBuildSummaryPlugin.m to fix Windows filepath issue.
Feb 3, 2026
5893f74
Use makeValidName instead of uuid
Feb 3, 2026
1a3d7e7
Update warning text
Feb 3, 2026
d88bc0f
Add unit tests for parallelizable build summary plugin
Feb 3, 2026
5ef6f3c
Update version to prerelease
Feb 3, 2026
b66cb64
Add the GHA run number into the artifact name in the test.
Feb 3, 2026
b03f024
I am dumb and missed updating one of the test cases
Feb 3, 2026
e72f7c4
Simplify plugin constructor
Feb 3, 2026
588a9e1
Update bat.yml indentation to a consistent 2 spaces.
sameagen-MW Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions plugins/+buildframework/ParallelizableBuildSummaryPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
classdef ParallelizableBuildSummaryPlugin < matlab.buildtool.plugins.BuildRunnerPlugin

% Copyright 2025 The MathWorks, Inc.
% Copyright 2025-2026 The MathWorks, Inc.

properties
TempFolder
Expand Down Expand Up @@ -44,18 +44,28 @@ function runBuild(plugin, pluginData)
function runTask(plugin, pluginData)
runTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData);

name = fullfile(plugin.TempFolder, pluginData.Name + ".mat");
name = fullfile(plugin.TempFolder, matlab.lang.internal.uuid() + ".mat");

@mcafaro mcafaro Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid using internal packages, especially in code outside of the base product like this. What about using matlab.lang.makeValidName to turn the task name into a valid identifier, which should also be a valid filename?

taskDetail = getCommonTaskDetail(pluginData);
save(name, "taskDetail");

try
save(name, "taskDetail");
catch e
warning("buildframework:BuildSummaryPlugin:UnableToSaveTrace", "Unable to save an artifact required to create the MATLAB build summary table");

@mcafaro mcafaro Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this review but these error/warning ids and package names are not currently consistent with our guidelines. The first component should relate to the product containing the code (I believe we use "ciplugins" on Jenkins). I opened an issue to track this: #4

end
end

function skipTask(plugin, pluginData)
skipTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData);

name = fullfile(plugin.TempFolder, pluginData.Name + ".mat");
name = fullfile(plugin.TempFolder, matlab.lang.internal.uuid() + ".mat");
taskDetail = getCommonTaskDetail(pluginData);
taskDetail.skipReason = pluginData.SkipReason;
save(name, "taskDetail");

try
save(name, "taskDetail");
catch e
warning("buildframework:BuildSummaryPlugin:UnableToSaveTrace", "Unable to save an artifact required to create the MATLAB build summary table");
end
end
end
end
Expand Down