Skip to content

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Sep 26, 2025

Description:

While developing some new routes, I noticed that despite having CACHING_ENABLED set to false in my local config, I had to manually clear the route cache file each time I made a route path change. The line I changed appears to be doing the opposite of what you would expect and only caching routes when caching is disabled.

Review

@snake14
Copy link
Contributor Author

snake14 commented Oct 5, 2025

I tagged Core Team for review, but I just realised that maybe I should have tagged Websites Team instead. @textagroup Do you know whether there's a specific reason the CACHING_ENABLED constant was set the way it was? To me, it seems like it's doing the opposite of what it should be doing on the line that I'm changing in this PR.

@snake14
Copy link
Contributor Author

snake14 commented Oct 13, 2025

I tagged Core Team for review, but I just realised that maybe I should have tagged Websites Team instead. @textagroup Do you know whether there's a specific reason the CACHING_ENABLED constant was set the way it was? To me, it seems like it's doing the opposite of what it should be doing on the line that I'm changing in this PR.

Any idea about my question above @Frankie75321 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant