-
Notifications
You must be signed in to change notification settings - Fork 507
Brands renaming #8109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Brands renaming #8109
Conversation
|
@sgiehl since you resolved the comments about removal of short names, should I apply the same logic to other PRs from me? |
|
@Simbiat generally yes, but to avoid more merge conflicts it might be better to wait 🤔 |
|
Resolved all comments from above besides Techmade, since I am not sure that's the same brand as on Techmade.eu |
|
So, what's stopping us from merge? I'd like to update the other PRs with similar logic for "removed" brands |
|
bump |
|
Kind reminder |
|
@sgiehl I've reviewed the changes, all are fine for me. @sanchezzzhak if you can take a second look please? |
Description:
Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious
Review