Skip to content

Conversation

@Simbiat
Copy link
Contributor

@Simbiat Simbiat commented Sep 21, 2025

Description:

Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious

Review

@Simbiat
Copy link
Contributor Author

Simbiat commented Nov 19, 2025

@sgiehl since you resolved the comments about removal of short names, should I apply the same logic to other PRs from me?

@sgiehl
Copy link
Member

sgiehl commented Nov 19, 2025

@Simbiat generally yes, but to avoid more merge conflicts it might be better to wait 🤔

@Simbiat
Copy link
Contributor Author

Simbiat commented Nov 19, 2025

Resolved all comments from above besides Techmade, since I am not sure that's the same brand as on Techmade.eu

@Simbiat
Copy link
Contributor Author

Simbiat commented Dec 15, 2025

So, what's stopping us from merge? I'd like to update the other PRs with similar logic for "removed" brands

@Simbiat
Copy link
Contributor Author

Simbiat commented Dec 30, 2025

bump

@Simbiat
Copy link
Contributor Author

Simbiat commented Jan 15, 2026

Kind reminder

@liviuconcioiu
Copy link
Collaborator

@sgiehl I've reviewed the changes, all are fine for me. @sanchezzzhak if you can take a second look please?

@Simbiat Simbiat mentioned this pull request Jan 21, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants