Skip to content

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 9, 2025

Description:

It has been reported that diacritics are causing problems when using the segment search.

If a segment names e.g. contains letter like Çàêč or similar, those segment would not be found when searching for caec.
This makes it hard in some languages to search for segments.

This PR changes the segment search, so it compares the search term with the original segment name, but also with the normalized segment name. This way you can search for a, but would find a and à, while searching for à, would only find à

Review

@sgiehl sgiehl force-pushed the fuzzy-segment-search branch 2 times, most recently from cc0c9c9 to 71a70e2 Compare July 14, 2025 06:12
@sgiehl sgiehl force-pushed the fuzzy-segment-search branch from 5450805 to 6b2e16e Compare July 25, 2025 14:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Aug 9, 2025
@sgiehl sgiehl force-pushed the fuzzy-segment-search branch 6 times, most recently from 5bcb1e5 to b8404c4 Compare October 2, 2025 13:52
@sgiehl sgiehl force-pushed the fuzzy-segment-search branch 2 times, most recently from 6ce5ddb to 5364e80 Compare October 8, 2025 09:33
@sgiehl sgiehl force-pushed the fuzzy-segment-search branch from 5364e80 to 425ff5d Compare October 9, 2025 10:14
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale for long The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants