Migrate annotations to a separate db table, update model, update tests#23564
Merged
Conversation
* Create a model for annotations in a separate db table * Add index in a separate db call * Remove private var table until needed * Only create table and add index if needed * Update UI test screenshot * Update version to 5.4.1-b1 as the minor will go stable in the meantime * Add user to new annotations db table * Target version 5.5.0-b1 * Remove id from db table index * Remove install and uninstall methods from model class * Remove install/uninstall calls * Update plugins/Annotations/Annotations.php --------- Co-authored-by: Marc Neudert <marc@innocraft.com>
# Conflicts: # core/Db/Schema/Mysql.php # core/Version.php # plugins/Annotations/Model.php
…king # Conflicts: # core/Updates/5.5.0-b1.php
# Conflicts: # core/Version.php
# Conflicts: # core/Version.php
Contributor
Author
|
@mneudert I think all the feedback has been addressed, can you please have another look? Thanks! |
mneudert
reviewed
Sep 15, 2025
Contributor
|
Happy that @mneudert 's concerns have been addressed. Also happy with the system/integration tests covering most cases, this looks good to go. |
caddoo
previously approved these changes
Sep 23, 2025
sgiehl
approved these changes
Sep 24, 2025
sgiehl
left a comment
sgiehl
left a comment
Member
There was a problem hiding this comment.
The new test related changes look fine. So assuming the previous reviews were complete, this should now be ready to merge.
michalkleiner
dismissed
mneudert’s stale review
approved by Matt and Stefan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Note: could probably do without the array flattening helper but it feels it made the code a bit more legible in terms of what belongs to each migration.
Review