Refs #23342 - Manage Live API Model Offset / Count / timeframe split correctly and more memory efficient

[peterbo]

Description:

Refs #23342

Try to fix the Live API Model to:

• handle the offset correctly (e.g. &filter_offset=377000&filter_limit=200 always created wrong / empty results)
• only count necessary data from offset (memory efficient)
• split dates into multiple queries created overlapping timeframes

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Hi @peterbo, thanks so much for creating the PR and looking into the offset problem.
Since no tests were added and nothing started to fail, it looks like the behaviour that previously didn't work (based on the issue) wasn't covered by a test. Do you think you would have time to also add a new test that we can run before/after this PR to validate it fixes the problem?

[peterbo]

Hi @michalkleiner, I have no test suite / dev running on my environment. I have to prepare it and make it work. It'll take some time though.

[michalkleiner]

Thanks @peterbo, that's understandable. If it's of any help, Matomo comes with DDEV project config and it should be quite straightforward setting one up for development, if you wanted to give it a go. Check out https://github.com/matomo-org/matomo/blob/5.x-dev/.ddev/README.md.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.