Fix and Improve period selection via keyboard navigation #23768
+187
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzi
force-pushed
the
ux-300
branch
3 times, most recently
from
c9eab06 to
cf6189f
Compare
tzi
added
the
Pull Request WIP
10 tasks
tzi
force-pushed
the
ux-300
branch
2 times, most recently
from
7fa9098 to
c6a3a02
Compare
tzi
force-pushed
the
ux-300b
branch
4 times, most recently
from
73144e6 to
909c0c6
Compare
tzi
added
Enhancement
tzi
commented
Nov 18, 2025
| event: MouseEvent|KeyboardEvent, | ||
| ) { | ||
| if (element.classList.contains('expanded')) { | ||
| close(element, binding, event); |
Contributor
Author
There was a problem hiding this comment.
ℹ️ Restructure this part because onExpand triggered a toggle, so it was also used to close without user event triggered.
tzi
commented
Nov 18, 2025
| binding.value.isMouseDown = false; | ||
| binding.value.hasScrolled = false; | ||
| element.classList.remove('expanded'); | ||
| close(element, binding, event); |
Contributor
Author
There was a problem hiding this comment.
ℹ️ There was no onClosed event triggered either here.
tzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX-300
Fix period selection with keyboard navigation
It was impossible to open the period selection form.
Checklist
Review