Skip to content

Conversation

@chippison
Copy link
Contributor

@chippison chippison commented Nov 13, 2025

Description

UX-305
We no longer want to show multiple error messages on screen when the session ends either with the user just leaving the computer for a long time or the session cookie was deleted. We want to redirect the user to login page when this happens

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@chippison chippison marked this pull request as ready for review November 16, 2025 19:28
@michalkleiner michalkleiner changed the title UX-305: Redirect to login page when session ends Redirect to login page when session ends Nov 16, 2025
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way how to test this in a UI test? We can load a dashboard, log the user out or delete their session cookie or similar, and reload the UI with the expectation of them landing on the log in page.

@michalkleiner michalkleiner requested a review from a team November 19, 2025 04:02
@chippison chippison requested a review from sgiehl November 21, 2025 06:33
@sgiehl sgiehl added this to the 5.7.0 milestone Nov 21, 2025
@sgiehl sgiehl added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 21, 2025
@chippison chippison requested a review from sgiehl November 23, 2025 20:50
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've did some further local testing on this one. While it works nicely when switching between menu entries it now fails with a generic error if you e.g. click on the refresh icon in a dashboard widget.

As everything should use the AjaxLoader to load content it should work for all cases when moving the 401 check here:

}).fail((xhr: jqXHR) => {
if (xhr.status === 429) {
console.log(`Warning: the '${$.param(this.getParams)}' request was rate limited!`);
reject(xhr);
return;
}

@sgiehl sgiehl modified the milestones: Impact backlog, 5.7.0 Nov 24, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the change here instead of in WidgetLoader

Thanks @sgiehl

@chippison chippison requested a review from sgiehl November 24, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Development

Successfully merging this pull request may close these issues.

5 participants