Show success notification once a Goal has been created or updated #23809
+205
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f adding the segment into the store to finish before we 'mark' icons as 'compared'
…of 'data_comparison_segment_limit' to include the count for the first segment to compare (Usually 'All Visits').
… will stop click events on the element
…lick event to 'markCurrentSegment'
…se this does not allow us to show the notifications. We now just load the new goals by calling via api and updating the view
…. This makes it faster as well as being able to show the notification
…props if not found in goals list
fixing test
tzi
reviewed
Nov 24, 2025
tzi
reviewed
Nov 24, 2025
tzi
reviewed
Nov 24, 2025
| editGoal(goalId: string|number) { | ||
| this.showAddEditForm(); | ||
| const goal = this.goals[`${goalId}`] as Goal; | ||
| const goal = (this.goalsList[`${goalId}`] || this.goals[`${goalId}`]) as Goal; |
Contributor
There was a problem hiding this comment.
I understand now that goals is a prop value and goalsList a mutable variable. But, why do we have to go through both goalsList and goals?
Contributor
Author
There was a problem hiding this comment.
that is just incase 'this.goalsList' is null at some point. Just making sure that we always fallback to the default passed goals
nathangavin
approved these changes
Nov 25, 2025
Contributor
nathangavin
left a comment
nathangavin
left a comment
There was a problem hiding this comment.
Looks good to me, nice cleanup on the refresh of the goals list on goal creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX-333
Currently, when a Goal is edited and saved, no feedback is shown to the user.
After a Goal is successfully updated, display a success message at the top of the page.
Acceptance criteria:
Show a confirmation message like:
“Goal successfully updated. [View Goal Report]”
The “View Goal Report” link should direct to the corresponding Goal report page.
Checklist
Review