Skip to content

Adds code to ignore migration if no option is provided explicitly, #PG-5167#88

Merged
AltamashShaikh merged 5 commits into
5.x-devfrom
PG-5167
May 25, 2026
Merged

Adds code to ignore migration if no option is provided explicitly, #PG-5167#88
AltamashShaikh merged 5 commits into
5.x-devfrom
PG-5167

Conversation

@AltamashShaikh

Copy link
Copy Markdown
Contributor

Description

Adds code to ignore migration if no option is provided explicitly, like Y or y

Issue No

#PG-5167

Steps to Replicate the Issue

  1. Run the console command and press enter
    ./console migration:measurable --source-idsite=1 --target-db-host=127.0.0.1 --target-db-username=root --target-db-password =root_1234 --target-db-name=matomo_local --target-db-prefix=matomo_
  2. This will still work
  3. Checkout this PR and try performing the same request, it will abort the request

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@lachiebol lachiebol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'If you hit enter the migration continues even though the default option seems to be No. Can we just change the capital to Y rather than a N'

We're just going to default to false instead?

@AltamashShaikh AltamashShaikh merged commit 599dc29 into 5.x-dev May 25, 2026
7 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-5167 branch May 25, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants