Remove LegacyMembershipManager
#4862
Merged
+77
−703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests were only run with the legacy membership manager and are redundant with the memberhsip manager test spec.
toger5
force-pushed
the
toger5/remove-legacymemebershipmanager
branch
from
8de7202 to
5d9dfc9
Compare
robintown
approved these changes
Jun 23, 2025
| expect(sendDelayedStateMock).toHaveBeenCalledTimes(1); | ||
| } | ||
|
|
||
| it("sends events", async () => { |
There was a problem hiding this comment.
Are this and the tests below it being removed because they never were testing the new membership manager?
| @@ -77,6 +76,7 @@ export interface MembershipConfig { | |||
| * Use the new Manager. | |||
| * | |||
| * Default: `false`. | |||
| * @deprecated does nothing anymore we always default to the new memberhip manager. | |||
There was a problem hiding this comment.
I see, so this isn't even a breaking change as we're not exporting the membership managers to begin with. Nice 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy membership manager was kept around during the transition phase. It is now in a spot where we dont use it anymore and where we are getting better results with the new implementation.
This removes all related code and deprecates fields related to it so that downstream projects can adjust. (in particular:
useNewMembershipManager)There was a custom test file that tested both (new and legacy implementation) this file used describe.each and now just became a simple describe. All helper code for this setup also got removed.
Checklist
public/exportedsymbols have accurate TSDoc documentation.