Skip to content

Factor out common code for processing to-device events #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 4, 2025

sliding-sync-sdk.ts and sync.ts both have copies of this code, and it's redundant.

@richvdh richvdh requested a review from a team as a code owner June 4, 2025 21:50
@richvdh richvdh added the T-Task Tasks for the team like planning label Jun 4, 2025
@richvdh richvdh requested review from dbkr and MidhunSureshR June 4, 2025 21:50
`sliding-sync-sdk.ts` and `sync.ts` both have copies of this code, and it's
redundant.
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richvdh richvdh added this pull request to the merge queue Jun 5, 2025
Merged via the queue into develop with commit 99972ce Jun 5, 2025
32 checks passed
@richvdh richvdh deleted the rav/refactor_process_to_device_events branch June 5, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants