cleanup: Remove deprecated rtc room key transport #5119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
reviewed
Jan 9, 2026
| expect(client.cancelPendingEvent).toHaveBeenCalledWith(eventSentinel); | ||
| }); | ||
|
|
||
| it("re-sends key if a new member joins even if a key rotation is in progress", async () => { |
Member
There was a problem hiding this comment.
Were all these test deletions intentional? I'm seeing a lot of test titles that sound like they'd still be relevant to the to-device key transport. Or are they duplicated somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the now deprecated room key transport (keys are using to-device transport now). Also removes the old EncryptionManager (replaced by the RtcEncryptionManager)
Side Effect:
I noticed that there was a problem with
statisticobject, the to-device transport is itself updating thesent/receivecount, but the room transport was expecting the encryption manager to do it before/after calling the transport.I updated that and made it a responsability of the transport, the EncryptionManger now don't touch the statistic object
Checklist
public/exportedsymbols have accurate TSDoc documentation.