Skip to content

Harden CI with pinned action versions and Zizmor analysis#66

Merged
kaylendog merged 9 commits intomainfrom
ci/kaylendog/zizmor
Mar 10, 2026
Merged

Harden CI with pinned action versions and Zizmor analysis#66
kaylendog merged 9 commits intomainfrom
ci/kaylendog/zizmor

Conversation

@kaylendog
Copy link
Copy Markdown
Contributor

@kaylendog kaylendog commented Mar 9, 2026

This PR hardens the various CI workflows in the repo.

  • Updates actions to latest available versions, since many were a few years out of date.
  • Disables credential persistence by actions/checkout, since we don't do any pushing back to the remote.
  • ⚠️ Disables caching for the release workflow.
  • Uses the gh CLI in place of third-party actions.

Fixes #65

@kaylendog kaylendog self-assigned this Mar 9, 2026
Comment thread .github/workflows/release.yml
@kaylendog kaylendog force-pushed the ci/kaylendog/zizmor branch from 566b8d5 to 85063ba Compare March 10, 2026 11:14
@kaylendog kaylendog changed the title Pin action versions and harden workflows Harden CI with pinned action versions and Zizmor analysis Mar 10, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@kaylendog kaylendog marked this pull request as ready for review March 10, 2026 11:16
@kaylendog kaylendog requested a review from andybalaam March 10, 2026 14:08
Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@kaylendog kaylendog merged commit 9199cc3 into main Mar 10, 2026
7 of 12 checks passed
@AndrewFerr
Copy link
Copy Markdown
Member

For posterity, this PR left the release workflow in a unusable state, and had to be fixed by a few follow-up PRs:

So if a similar PR as this is made on other repos, findings from the above PRs should be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github actions should refer to commit IDs

4 participants