-
Notifications
You must be signed in to change notification settings - Fork 334
feat(wasm): complete PR of all wasm related changes to compile matrix-sdk-ffi bindings #5127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
From bindings/matrix-sdk-ffi, this can be compiled with the following command: |
One thought looking at this, would I be better off exporting the 'useful' things from matrix-sdk-common from the matrix-sdk crate, instead of adding more deps onto matrix-sdk-common externally? |
b5b9905
to
7a33aac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5127 +/- ##
==========================================
- Coverage 85.87% 85.83% -0.04%
==========================================
Files 338 339 +1
Lines 37070 37392 +322
==========================================
+ Hits 31834 32096 +262
- Misses 5236 5296 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa7f596
to
8cd3431
Compare
reqwest::{Certificate, Proxy}, | ||
SqliteStoreConfig, | ||
}; | ||
use matrix_sdk_common::runtime::get_runtime_handle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi just wanted to point out that this line seems to break things on this branch.
filament-dm@2a14077 moved this to the ffi crate itself and filament-dm@9f117ca introduced this line then at this place on this branch. With this line it doesnt compile but without it will. Noticed this while trying to build aurora bindings :)
Here is a complete PR that contains all changes needed to compile the matrix-sdk-ffi bindings on a wasm PR. This is not intended to be reviewed/merged, but serve as a reference for the other smaller PRs with an e2e working example.
The first 5 commits on this branch correspond to separate PRs that have already been opened. The last mega-commit needs to be broken up further after those 5 commits have landed.
The remaining changes correspond to roughly:
With these bindings, it is possible to use https://github.com/jhugman/uniffi-bindgen-react-native to generate JS/TS bindings that are callable from normal JS code for all elements marked as uniffi.
Signed-off-by: Daniel Salinas