Skip to content

Conversation

multisme
Copy link
Contributor

@multisme multisme commented Oct 13, 2025

Verify if the membership is not Leave when checking if a name in a room is ambiguous.

Signed-off-by:
multi

Fix #5774

@multisme multisme requested a review from a team as a code owner October 13, 2025 20:22
@multisme multisme requested review from stefanceriu and removed request for a team October 13, 2025 20:22
@multisme
Copy link
Contributor Author

It's pretty straightforward but should I had some tests?

@multisme multisme force-pushed the fix_check_if_user_really_ambiguous branch from b1cd305 to 47488fd Compare October 13, 2025 20:24
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.42%. Comparing base (588d604) to head (47488fd).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5780      +/-   ##
==========================================
- Coverage   88.43%   88.42%   -0.01%     
==========================================
  Files         360      360              
  Lines       99796    99797       +1     
  Branches    99796    99797       +1     
==========================================
- Hits        88250    88246       -4     
- Misses       7405     7411       +6     
+ Partials     4141     4140       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #5780 will not alter performance

Comparing multisme:fix_check_if_user_really_ambiguous (47488fd) with main (7185fcb)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Room member display names incorrectly marked as ambiguous

1 participant