Test alternate storage types for Ruma identifiers#6187
Draft
zecakeh wants to merge 15 commits intomatrix-org:mainfrom
Draft
Test alternate storage types for Ruma identifiers#6187zecakeh wants to merge 15 commits intomatrix-org:mainfrom
zecakeh wants to merge 15 commits intomatrix-org:mainfrom
Conversation
Arc storage type for Ruma identifiers
Arc storage type for Ruma identifiers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6187 +/- ##
=======================================
Coverage 89.90% 89.91%
=======================================
Files 371 371
Lines 102272 102272
Branches 102272 102272
=======================================
+ Hits 91943 91953 +10
+ Misses 6770 6761 -9
+ Partials 3559 3558 -1 ☔ View full report in Codecov by Sentry. |
5da1159 to
0be9700
Compare
4f43bf7 to
f9d1d1b
Compare
afcf61f to
57b8f58
Compare
3 tasks
2 tasks
As a fallback when the ID is not provided when constructing the event. It allows to work with data that looks like what we would get in production, which is important for benchmarks. Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the event IDs, and we use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the event IDs, and we use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
We generate an arbitrary hash for the event IDs, and we use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the event IDs, and we use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
Use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the event IDs, and we use the appropriate length for room IDs. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
6fc8437 to
d9a1aa1
Compare
4ae148c to
7b82fea
Compare
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged, I want to see how much changing the inner type of
Owned*identifiers influences codspeed benchmarks.