Skip to content

Test alternate storage types for Ruma identifiers#6187

Draft
zecakeh wants to merge 15 commits intomatrix-org:mainfrom
zecakeh:bench-storage
Draft

Test alternate storage types for Ruma identifiers#6187
zecakeh wants to merge 15 commits intomatrix-org:mainfrom
zecakeh:bench-storage

Conversation

@zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Feb 18, 2026

This is not meant to be merged, I want to see how much changing the inner type of Owned* identifiers influences codspeed benchmarks.

@zecakeh zecakeh changed the title Test Arc storage type Test Arc storage type for Ruma identifiers Feb 18, 2026
@zecakeh zecakeh changed the title Test Arc storage type for Ruma identifiers Test alternate storage type for Ruma identifiers Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (02d0298) to head (c3c7334).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6187   +/-   ##
=======================================
  Coverage   89.90%   89.91%           
=======================================
  Files         371      371           
  Lines      102272   102272           
  Branches   102272   102272           
=======================================
+ Hits        91943    91953   +10     
+ Misses       6770     6761    -9     
+ Partials     3559     3558    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks
🆕 49 new benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Memory Event cache find_event_relations[SQLite][100 events, #no filter] N/A 80.9 KB N/A
🆕 Memory Event cache find_event_relations[memory][1000 events, #no filter] N/A 714 KB N/A
🆕 Memory Event cache room updates[SQLite][room count: 10] N/A 10.6 MB N/A
🆕 Memory Event cache find_event_relations[memory][100 events, edits filter] N/A 74.6 KB N/A
🆕 Memory Event cache find_event_relations[SQLite][10 events, edits filter] N/A 13.3 KB N/A
🆕 Memory Event cache find_event_relations[memory][100 events, #no filter] N/A 74.6 KB N/A
🆕 Memory Event cache find_event_relations[SQLite][10 events, #no filter] N/A 12.6 KB N/A
🆕 Memory Event cache find_event_relations[SQLite][1000 events, #no filter] N/A 776.8 KB N/A
🆕 Memory Event cache room updates[memory][room count: 10] N/A 14.9 MB N/A
🆕 Memory Event cache room updates[SQLite][room count: 1] N/A 2.1 MB N/A
🆕 Memory Event cache find_event_relations[memory][10 events, edits filter] N/A 6.8 KB N/A
🆕 Memory Event cache find_event_relations[SQLite][1000 events, edits filter] N/A 776.5 KB N/A
🆕 Memory Event cache find_event_relations[memory][1000 events, edits filter] N/A 714 KB N/A
🆕 Memory Event cache room updates[SQLite][room count: 100] N/A 96.4 MB N/A
🆕 Memory Event cache room updates[memory][room count: 100] N/A 141.7 MB N/A
🆕 Memory Event cache room updates[memory][room count: 1] N/A 2.2 MB N/A
🆕 Memory Event cache find_event_relations[memory][10 events, #no filter] N/A 6.8 KB N/A
🆕 Memory Event cache find_event_relations[SQLite][100 events, edits filter] N/A 81.2 KB N/A
🆕 Memory Create[1000 rooms × 1000 events] N/A 646 KB N/A
🆕 Memory Restore session [SQLite][encrypted] N/A 62.4 MB N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing zecakeh:bench-storage (72b1265) with main (20d1087)

Open in CodSpeed

@zecakeh zecakeh changed the title Test alternate storage type for Ruma identifiers Test alternate storage types for Ruma identifiers Feb 23, 2026
@zecakeh zecakeh force-pushed the bench-storage branch 7 times, most recently from 4f43bf7 to f9d1d1b Compare February 24, 2026 12:40
zecakeh added 8 commits March 4, 2026 15:30
As a fallback when the ID is not provided when constructing the event.
It allows to work with data that looks like what we would get in
production, which is important for benchmarks.

Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the
event IDs, and we use the appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the
event IDs, and we use the appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
We generate an arbitrary hash for the event IDs, and we use the
appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the
event IDs, and we use the appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
Use the appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
We rely on the EventFactory to generate a hash of the events for the
event IDs, and we use the appropriate length for room IDs.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh force-pushed the bench-storage branch 3 times, most recently from 6fc8437 to d9a1aa1 Compare March 4, 2026 15:42
@zecakeh zecakeh force-pushed the bench-storage branch 2 times, most recently from 4ae148c to 7b82fea Compare March 4, 2026 15:57
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh added 2 commits March 4, 2026 18:38
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants