Skip to content

feat(threads): convert the types exposed from Room.list_threads to UI crates TimelineItem types#6278

Open
stefanceriu wants to merge 2 commits intomainfrom
stefan/threadLists
Open

feat(threads): convert the types exposed from Room.list_threads to UI crates TimelineItem types#6278
stefanceriu wants to merge 2 commits intomainfrom
stefan/threadLists

Conversation

@stefanceriu
Copy link
Member

Following #5953 this PR first correctly exposes ThreadRoots fields over FFI and then modifies the whole flow so UI crate timeline types are used instead, briging threads closer to what we do for latest events, reply details etc.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (af8236d) to head (f379c4f).
⚠️ Report is 35 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/threads.rs 0.00% 62 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/traits.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6278      +/-   ##
==========================================
- Coverage   89.90%   89.85%   -0.06%     
==========================================
  Files         372      373       +1     
  Lines      102463   102528      +65     
  Branches   102463   102528      +65     
==========================================
+ Hits        92123    92126       +3     
- Misses       6787     6850      +63     
+ Partials     3553     3552       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will improve performance by 69.42%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 49 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 282 ms 166.4 ms +69.42%

Comparing stefan/threadLists (f379c4f) with main (acda2e8)

Open in CodSpeed

@stefanceriu stefanceriu marked this pull request as ready for review March 12, 2026 10:43
@stefanceriu stefanceriu requested a review from a team as a code owner March 12, 2026 10:43
@stefanceriu stefanceriu requested review from Hywan and removed request for a team March 12, 2026 10:43
@stefanceriu stefanceriu force-pushed the stefan/threadLists branch 4 times, most recently from 73c4ec6 to 1741339 Compare March 13, 2026 06:58
…UI crates TimelineItem types

... and closer to what we do for latest events, reply details etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant