feat(threads): convert the types exposed from Room.list_threads to UI crates TimelineItem types#6278
Open
stefanceriu wants to merge 2 commits intomainfrom
Open
feat(threads): convert the types exposed from Room.list_threads to UI crates TimelineItem types#6278stefanceriu wants to merge 2 commits intomainfrom
Room.list_threads to UI crates TimelineItem types#6278stefanceriu wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6278 +/- ##
==========================================
- Coverage 89.90% 89.85% -0.06%
==========================================
Files 372 373 +1
Lines 102463 102528 +65
Branches 102463 102528 +65
==========================================
+ Hits 92123 92126 +3
- Misses 6787 6850 +63
+ Partials 3553 3552 -1 ☔ View full report in Codecov by Sentry. |
Merging this PR will improve performance by 69.42%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | Restore session [memory store] |
282 ms | 166.4 ms | +69.42% |
Comparing stefan/threadLists (f379c4f) with main (acda2e8)
73c4ec6 to
1741339
Compare
…UI crates TimelineItem types ... and closer to what we do for latest events, reply details etc.
1741339 to
f379c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #5953 this PR first correctly exposes
ThreadRootsfields over FFI and then modifies the whole flow so UI crate timeline types are used instead, briging threads closer to what we do for latest events, reply details etc.