Skip to content

MSC4230: Flag for animated images#4230

Merged
turt2live merged 16 commits into
mainfrom
dbkr/animated-image-flag
Feb 15, 2026
Merged

MSC4230: Flag for animated images#4230
turt2live merged 16 commits into
mainfrom
dbkr/animated-image-flag

Conversation

@dbkr
Copy link
Copy Markdown
Member

@dbkr dbkr commented Nov 21, 2024 •
edited by turt2live
Loading

Proposes adding a boolean flag to images that indicates whether they're animated.

Impl: element-hq/element-web#28513

Rendered

Disclosure: This is presented wearing my, "Element Employee and Element Web Engineer" hat.

FCP tickyboxes

MSC checklist

@dbkr dbkr mentioned this pull request Nov 21, 2024
Merged
@turt2live turt2live added proposal A matrix spec change proposal. Process state. A-Client Server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 21, 2024
@turt2live turt2live marked this pull request as draft November 21, 2024 16:24
@dbkr dbkr marked this pull request as ready for review November 21, 2024 17:07
@dbkr dbkr changed the title [Placeholder] Flag for animated images Flag for animated images Nov 21, 2024
@dbkr dbkr changed the title Flag for animated images [MSC4230]: Flag for animated images Nov 21, 2024
@dbkr dbkr changed the title [MSC4230]: Flag for animated images MSC4230: Flag for animated images Nov 21, 2024
sumnerevans
sumnerevans reviewed Nov 21, 2024
View reviewed changes
Comment thread proposals/4230-animated-image-flag.md Outdated
MidhunSureshR
MidhunSureshR reviewed Nov 22, 2024
View reviewed changes
Comment thread proposals/4230-animated-image-flag.md Outdated
@dbkr @MidhunSureshR
Typo
4078173 
Co-authored-by: R Midhun Suresh <rmidhunsuresh@gmail.com>
HarHarLinks
HarHarLinks reviewed Dec 2, 2024
View reviewed changes
Comment thread proposals/4230-animated-image-flag.md Outdated
Comment thread proposals/4230-animated-image-flag.md Outdated
Half-Shot
Half-Shot reviewed Dec 6, 2024
View reviewed changes
Comment thread proposals/4230-animated-image-flag.md Outdated
@dbkr @Half-Shot
Not a string
e550201 
Co-authored-by: Will Hunt <will@half-shot.uk>
@zecakeh zecakeh mentioned this pull request Dec 28, 2024
Merged
@zecakeh
Copy link
Copy Markdown
Contributor

zecakeh commented Jan 13, 2025

This is implemented in Fractal too as of today:

@nebulade nebulade mentioned this pull request Feb 6, 2025
Open
@dbkr dbkr removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Feb 19, 2025
@dbkr
Copy link
Copy Markdown
Member Author

dbkr commented Feb 19, 2025

As per discussion on element-hq/element-web#28311 and since this now has 2 impls, I'm going to

@mscbot fcp merge

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 19, 2025 •
edited
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • Checklist incomplete

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. disposition-merge Process state. labels Feb 19, 2025
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Nov 18, 2025

@dbkr this is expected to get put back on the SCT's radar soon - are you able to take a look and resolve some of the open threads?

@turt2live turt2live added the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Jan 6, 2026
@turt2live @HarHarLinks
Apply suggestions from code review
fbb7e60 
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 10, 2026

I've made the executive decision to resolve the only outstanding thread.

@mscbot resolve Checklist incomplete

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 10, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period Process state to accept, reject, or postpone an MSC. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. unresolved-concerns This proposal has at least one outstanding concern. Process state. labels Feb 10, 2026
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Feb 10, 2026
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Feb 10, 2026
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 15, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period FCP has finished. Process state. and removed disposition-merge Process state. final-comment-period Process state to accept, reject, or postpone an MSC. labels Feb 15, 2026
@turt2live turt2live merged commit 5a75182 into main Feb 15, 2026
1 check passed
@turt2live turt2live moved this from In FCP to Requires spec writing in Spec Core Team Workflow Feb 15, 2026
@turt2live turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Feb 15, 2026
@zecakeh
Copy link
Copy Markdown
Contributor

zecakeh commented Mar 4, 2026

Spec PR: matrix-org/matrix-spec#2328

@HarHarLinks HarHarLinks mentioned this pull request Mar 4, 2026
Open
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Mar 4, 2026
@turt2live turt2live moved this from Requires spec writing to Requires spec PR review in Spec Core Team Workflow Mar 4, 2026
@richvdh richvdh moved this from Requires spec PR review to Merged/Done in Spec Core Team Workflow Mar 10, 2026
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Mar 10, 2026

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Mar 10, 2026
@zecakeh zecakeh mentioned this pull request Mar 16, 2026
Merged
@zecakeh zecakeh mentioned this pull request Mar 26, 2026
Open
54 tasks
@spantaleev spantaleev mentioned this pull request May 10, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clokep clokep clokep left review comments

@Johennes Johennes Johennes left review comments

@turt2live turt2live turt2live left review comments

@richvdh richvdh richvdh left review comments

@Half-Shot Half-Shot Half-Shot left review comments

@tulir tulir tulir left review comments

@MidhunSureshR MidhunSureshR MidhunSureshR left review comments

@erikjohnston erikjohnston erikjohnston left review comments

+3 more reviewers

@TheArcaneBrony TheArcaneBrony TheArcaneBrony left review comments

@sumnerevans sumnerevans sumnerevans left review comments

@HarHarLinks HarHarLinks HarHarLinks requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Client Server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Status: Merged/Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.