MSC4386: Automatically sharing secrets after device verification #4386
+206
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
changed the title
uhoreg
added
e2e
proposal
turt2live
reviewed
Dec 8, 2025
Member
There was a problem hiding this comment.
Implementation requirements:
- Sending client
- Receiving client (ideally different from the sending one)
Johennes
reviewed
Dec 11, 2025
| "m.cross_signing.self_signing", | ||
| "m.cross_signing.user_signing" | ||
| ], | ||
| "requested": ["org.example.custom"] |
Contributor
There was a problem hiding this comment.
Wouldn't DEVICEB already know that DEVICEA cannot provide this secret based on the earlier verification request?
Johennes
reviewed
Dec 11, 2025
|
|
||
| ## Potential issues | ||
|
|
||
| None? |
Contributor
There was a problem hiding this comment.
When using in-room verification, I think, you could theoretically run into the 64KiB event size limit? Secrets stored in account data won't be subject to this limit. Even if they were, you could exceed it because multiple secrets are combined in a single m.key.verification.secrets event.
This is probably not a practical problem because secrets should normally be relatively small. So I'm not sure if we really need to do anything. Maybe a dedicated error code at most?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Disclosure: I am a member of the Element crypto team, and of the Spec Core Team. This proposal is written as a member of the Element crypto team.