Skip to content

Specify MSC4418: Make destination a required server authentication field #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
velikopter wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Specify MSC4418: Make destination a required server authentication field #2360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f83350
Specify MSC4418: Make `destination` a required server authentication …
velikopter Apr 22, 2026
118f712
newsfragment
velikopter Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/2360.breaking
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Require the `destination` field in server-to-server authentication. Contributed by @velikopter.
5 changes: 2 additions & 3 deletions content/server-server-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,10 @@ The authorization parameters to include are:
`origin` field from JSON described in step 1.
- `destination`: {{% added-in v="1.3" %}} the server name of the receiving
server. This is the same as the `destination` field from the JSON described
in step 1. For compatibility with older servers, recipients should accept
requests without this parameter, but MUST always send it. If this property
is included, but the value does not match the receiving server's name, the
in step 1. If the value does not match the receiving server's name, the
receiving server must deny the request with an HTTP status code 401
Unauthorized.
{{% changed-in v="1.19" %}} This field is now required.
- `key`: the ID, including the algorithm name, of the sending server's key used
to sign the request.
- `signature`: the signature of the JSON as calculated in step 1.
Expand Down
Loading