Use OpenAPI definition for EncryptedFile#2398
Merged
Merged
Conversation
... instead of the ad-hoc table we have currently.
zecakeh
reviewed
Jun 14, 2026
zecakeh
left a comment
zecakeh
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me, I just have nits about the string formats.
richvdh
changed the title
EncryptedFile.EncryptedFile
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
Member
Author
|
@zecakeh thanks for the review; you raise good points. Please take another look? |
zecakeh
approved these changes
Jun 16, 2026
zecakeh
left a comment
zecakeh
left a comment
Collaborator
There was a problem hiding this comment.
I have a last suggestion, but this looks ready to merge if you don't want to apply it.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of the ad-hoc table we have currently.
Since it uses url-safe unpadded base64, I specced that too.
Preview: https://pr2398--matrix-spec-previews.netlify.app