Fix: Set width and height attributes for Bluesky SVG#3122
Merged
HarHarLinks merged 1 commit intoDec 25, 2025
Merged
Conversation
Signed-off-by: Jack S. <181536874+awtj8o81ryywg793@users.noreply.github.com>
HarHarLinks
approved these changes
Dec 25, 2025
Contributor
HarHarLinks
left a comment
HarHarLinks
left a comment
There was a problem hiding this comment.
You're right, thank you. Not sure how this could have slipped through.
I wonder why these aren't styled using CSS instead anyway?
Contributor
Author
|
Quoted from a previous comment:
That wouldn't be a bad idea, though it doesn't hurt to have a "default" value defined as an attribute. |
Contributor
|
I tried in devtools and it seemed you can't override with css if an attribute is set 😕 |
Contributor
Author
|
Quoted from a previous comment:
I've just tried overwriting the styles via "Developer Tools," and I'm able to do so just fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
widthandheightattributes to the Bluesky icon SVG. The lack of these attributes is causing a visual bug. See #3121.Related issues
Closes #3121.
Role
Individual not affiliated with any project relevant to this PR.
Timeline
There’s no immediate deadline, but considering that the bug prevents users from clicking the Bluesky link, the sooner, the better.
Signoff
Please sign off your individual commits or whole pull request.