Add [m]-favicon custom emoji#3125
Merged
Merged
Conversation
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
HarHarLinks
added
enhancement
HarHarLinks
changed the title
|
Thanks — I learned a lot while working on the earlier attempt (#3124). |
MTRNord
approved these changes
Jan 6, 2026
Member
MTRNord
left a comment
MTRNord
left a comment
There was a problem hiding this comment.
This seems to be of higher quality than #3124 so preferring this one.
In case people want to learn the difference between the 2 and why this one is preferred:
The CSS is not inline but rather in our scss which is easier to read and makes it reusable if needed in the future without duplication and having to maintain 2 places.
Additionally, it also takes care of the twim post.
Finally, it also uses the non-dark mode aware icon we have in the repository. The one used by #3124 would have the wrong colour if the user uses dark mode on their system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new shortcode that allows authors to easily make use of the "[m]" favicon at emoji-size. Use case/example:
Related issues
Resolve #3106
Replaces the previous attempt at #3124
Role
🎩 Website & Content WG
Timeline
Signoff
Please sign off your individual commits or whole pull request.