Skip to content

Fix version comment on the workflow commit#3433

Merged
HarHarLinks merged 3 commits into
mainfrom
MTRNord/fix-rumdl-version-comment
May 27, 2026
Merged

Fix version comment on the workflow commit#3433
HarHarLinks merged 3 commits into
mainfrom
MTRNord/fix-rumdl-version-comment

Conversation

@MTRNord
Copy link
Copy Markdown
Member

@MTRNord MTRNord commented May 25, 2026

Description

Fixes zizmor complaining about the comment.

Fixes https://github.com/matrix-org/matrix.org/security/code-scanning/6

Related issues

N/A

Role

Website & Content WG

Timeline

N/A

Signoff

See commits

Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
@MTRNord MTRNord requested a review from a team as a code owner May 25, 2026 18:13
@MTRNord MTRNord added the enhancement This would be an improvement to the website. label May 25, 2026
@MTRNord MTRNord changed the title the commit points to this version and not v0 Fix version comment on the workflow commit May 25, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 25, 2026

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98de8ed
Status: ✅  Deploy successful!
Preview URL: https://f51fb087.matrix-website.pages.dev
Branch Preview URL: https://mtrnord-fix-rumdl-version-co.matrix-website.pages.dev

View logs

@HarHarLinks
Copy link
Copy Markdown
Contributor

oops, sorry for causing the need for conflict resolution by merging dependabot. maybe it would be easiest to push your fix to the dependabot PR next time?

@HarHarLinks HarHarLinks added dependencies Pull requests that update a dependency file meta Something concerning the repo itself, such as technical changes, contribution guidelines, and more. and removed enhancement This would be an improvement to the website. labels May 27, 2026
Comment thread .github/workflows/linter.yaml Outdated
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks HarHarLinks merged commit 2e61212 into main May 27, 2026
6 checks passed
@HarHarLinks HarHarLinks deleted the MTRNord/fix-rumdl-version-comment branch May 27, 2026 12:27
@MTRNord
Copy link
Copy Markdown
Member Author

MTRNord commented May 27, 2026

oops, sorry for causing the need for conflict resolution by merging dependabot. maybe it would be easiest to push your fix to the dependabot PR next time?

yeah next time will do that. Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file meta Something concerning the repo itself, such as technical changes, contribution guidelines, and more.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants