Support deployments using Matrix Authentication Service #577
+418
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested changes
Feb 28, 2025
| } | ||
| } | ||
|
|
||
| public async deactivateMasUser(userId: string): Promise<void> { |
There was a problem hiding this comment.
slight inconsistency in naming: is it MAS or Mas in functions? (either is fine - we should match existing styles if there's examples).
Comment on lines
+83
to
+91
| await axios({ | ||
| method: "post", | ||
| url: url, | ||
| headers: { | ||
| "User-Agent": "Mjolnir", | ||
| "Content-Type": "application/json; charset=UTF-8", | ||
| "Authorization": `Bearer ${accessToken.token.access_token}`, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
moving the axios calls to a doRequest function would be best, so if we need to update something it's a single code site. The getAccessToken() call can be in that function too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deactivate,/admin,/lock,/unlock) if MAS is in useAlso adds support for locking users in both MAS and non-MAS deployments.