This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Add metadata-action so labels are generated #426
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,21 +35,20 @@ jobs: | |
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Generate docker image tags | ||
| id: metadata | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: | | ||
| name=ghcr.io/${{ github.repository_owner }}/${{ github.repository }} | ||
| tags: | | ||
| type=ref,event=branch | ||
| type=ref,event=pr | ||
| type=semver,pattern={{raw}} | ||
| type=sha | ||
| type=raw,value=latest,enable=${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }} | ||
|
|
||
| - name: Build release Sliding Sync image | ||
| id: docker_build_sliding_sync_release | ||
| uses: docker/build-push-action@v4 | ||
| with: | ||
|
|
@@ -58,9 +57,8 @@ jobs: | |
| context: . | ||
| platforms: ${{ env.PLATFORMS }} | ||
| push: true | ||
|
Member
There was a problem hiding this comment. We seem to be losing the
Author
There was a problem hiding this comment. So the latest tag is no longer specified by docker/build-push-action@v4, but a list of tags (in this case I think only one) is created by docker/metadata-action@v5 See sliding-sync/.github/workflows/docker.yml Line 46 in 8bcd28b It'll create |
||
| tags: ${{ steps.metadata.outputs.tags }} | ||
| labels: ${{ steps.metadata.outputs.labels }} | ||
|
|
||
| - name: Run Trivy vulnerability scanner | ||
| uses: aquasecurity/trivy-action@master | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to lose the caching..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this diff is just because i merged them into the one docker/build-push-action@v4
Though that being said, i think the
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')should be removed so its always pushing an email? or did you only want images pushed for releases? its been a few weeks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No wait yes, the if: should be removed so it always builds the image, but maybe the
push: truecould be made into a conditional so only pushes the result sometimes?