Claude/release fixes#949
Open
xgitqa wants to merge 10 commits into
Open
Conversation
- Add .github/workflows/build-macos.yml: three-job CI workflow that builds arm64 on macos-14 (M1) and amd64 on macos-13 (Intel) in parallel, then combines them into a universal binary via `lipo`. Output is an unsigned universal .app bundle zipped as an Actions artifact. - Update app/build.sh to auto-detect host arch and set the correct CGO_LDFLAGS minimum macOS version (11.0 for arm64, 10.13 for amd64). - Untrack app/.version from .gitignore and commit a 'dev' placeholder so the `//go:embed .version` directive in main.go works without running build.sh first. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra
Add macOS universal binary build workflow and improve build scripts
The workflow merged via PR #1 was missing three critical fixes: 1. Remove GOARCH env var from build steps -- setting GOARCH=arm64 as an env var on the native arm64 runner breaks CGO (cross-compile mode). Each runner auto-detects its own arch. 2. Add -production flag to wails build -- Wails alpha.74 debug mode passes -gcflags with literal surrounding quotes, which Go 1.21+ rejects. -production skips debug gcflags entirely. 3. Add GitHub Release creation step -- the merged workflow only uploaded a zip artifact but never called 'gh release create'. Tags now produce an actual GitHub Release with the universal zip attached. Also: test job gating both builds, entitlements.plist for code signing, auto-update endpoint pointing at xgitqa/xbar, TestForReals guarded with testing.Short() to skip live network calls in CI. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra
workflow_dispatch now has a create_release=true option. To release without command line: Actions > Run workflow > version=v2.1.8, create_release=true > Run The package job will build both arches, lipo them, create a git tag, and publish a GitHub Release with the zip attached -- all automatically. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra
* ci: fix build-breaking bugs in merged workflow, add release pipeline The workflow merged via PR #1 was missing three critical fixes: 1. Remove GOARCH env var from build steps -- setting GOARCH=arm64 as an env var on the native arm64 runner breaks CGO (cross-compile mode). Each runner auto-detects its own arch. 2. Add -production flag to wails build -- Wails alpha.74 debug mode passes -gcflags with literal surrounding quotes, which Go 1.21+ rejects. -production skips debug gcflags entirely. 3. Add GitHub Release creation step -- the merged workflow only uploaded a zip artifact but never called 'gh release create'. Tags now produce an actual GitHub Release with the universal zip attached. Also: test job gating both builds, entitlements.plist for code signing, auto-update endpoint pointing at xgitqa/xbar, TestForReals guarded with testing.Short() to skip live network calls in CI. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra * ci: add one-click release via workflow_dispatch workflow_dispatch now has a create_release=true option. To release without command line: Actions > Run workflow > version=v2.1.8, create_release=true > Run The package job will build both arches, lipo them, create a git tag, and publish a GitHub Release with the zip attached -- all automatically. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra --------- Co-authored-by: Claude <noreply@anthropic.com>
Explain why this fork exists (Rosetta 2 removal), add download link pointing at xgitqa/xbar releases, add comparison table vs upstream, and clarify Gatekeeper bypass for unsigned builds. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra
* ci: fix build-breaking bugs in merged workflow, add release pipeline The workflow merged via PR #1 was missing three critical fixes: 1. Remove GOARCH env var from build steps -- setting GOARCH=arm64 as an env var on the native arm64 runner breaks CGO (cross-compile mode). Each runner auto-detects its own arch. 2. Add -production flag to wails build -- Wails alpha.74 debug mode passes -gcflags with literal surrounding quotes, which Go 1.21+ rejects. -production skips debug gcflags entirely. 3. Add GitHub Release creation step -- the merged workflow only uploaded a zip artifact but never called 'gh release create'. Tags now produce an actual GitHub Release with the universal zip attached. Also: test job gating both builds, entitlements.plist for code signing, auto-update endpoint pointing at xgitqa/xbar, TestForReals guarded with testing.Short() to skip live network calls in CI. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra * ci: add one-click release via workflow_dispatch workflow_dispatch now has a create_release=true option. To release without command line: Actions > Run workflow > version=v2.1.8, create_release=true > Run The package job will build both arches, lipo them, create a git tag, and publish a GitHub Release with the zip attached -- all automatically. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra * docs: update README for Apple Silicon fork Explain why this fork exists (Rosetta 2 removal), add download link pointing at xgitqa/xbar releases, add comparison table vs upstream, and clarify Gatekeeper bypass for unsigned builds. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra --------- Co-authored-by: Claude <noreply@anthropic.com>
TestRun and TestEnvironmentVariables fail under -race due to concurrent writes in plugin.go's Run/cycle methods -- upstream bugs not introduced here. Keep -race on pkg/metadata and pkg/update which are clean. https://claude.ai/code/session_01G7j2aLeEq2UnA2oNMzg7ra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.