Keep datasets on CPU #120
Merged
Keep datasets on CPU #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdumm
force-pushed
the
119-datasets-on-cpu
branch
from
4ce3aba to
42ee21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119 keeping DXSM datasets stored on CPU, except when batches are used in training.
tomethod will only changeself.device, but will not move data between devices. The data of a dataset can be moved between devices with themove_data_to_devicemethod, which must be implemented by all subclasses ofDXSMDataset. This method will only be called in__post_init__to ensure that all data is on the cpu. Any methods which should be executed onself.deviceshould now be responsible for moving the required data to that device.