Use multihit model by default #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsen
approved these changes
Jun 17, 2025
Contributor
matsen
left a comment
matsen
left a comment
There was a problem hiding this comment.
Yay!
I assume that this doesn't impact already-trained models.
Contributor
Author
|
That's right, the multihit model specified in the metadata is the one that will be used, and if the metadata doesn't specify one, none will be used (consistent with our old defaults). This only affects how new models will be trained. |
Contributor
|
Great! Merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the configuration that we use for training DASM models