Uniquely responsible activity and departure handlers #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… abort if more than one handler feels responsible
…e the previous code did not make sense
…ng; other activity handlers may be on top
… was added anyways to the departure handlers, thus now causing issues when the fall-through is always investigated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code would use the first departure/activity handler that felt responsible. Now it will check if there are more than one, and if so then abort.
(Since, with current design, the teleportation handler always feels responsible, the code needs to hedge against that. Might make sense to register teleportation handlers only for those modes mentioned in the config.)