consistently return default drt constraints #3709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulheinr
approved these changes
Feb 5, 2025
| public DrtOptimizationConstraintsSet addOrGetDefaultDrtOptimizationConstraintsSet() { | ||
| Optional<DrtOptimizationConstraintsSet> drtOptParams = getDrtOptimizationConstraintsSets().stream() | ||
| public DefaultDrtOptimizationConstraintsSet addOrGetDefaultDrtOptimizationConstraintsSet() { | ||
| Optional<DefaultDrtOptimizationConstraintsSet> drtOptParams = getDrtOptimizationConstraintsSets().stream() | ||
| .filter(params -> params.name.equals(defaultConstraintSet)) |
There was a problem hiding this comment.
If someone implements another type of DrtOptimizationConstraintSet and assign "default" as name of this set, then this function would create another optimization constraint set with the name "default" and with the type DefaultDrtOptimizationConstraintSet. Since we at VSP will probably never use other parameter sets than the Default... one, this is okay I guess. But this can be confusing.
luchengqi7
approved these changes
Feb 6, 2025
luchengqi7
approved these changes
Feb 6, 2025
|
@nkuehnel I think you need to update the base branch for a merge |
|
@jfbischoff yes, plz dont merge yet, I am thinking of changing it a bit further :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luchengqi7 @kainagel @paulheinr
Could you have a look at this PR?
This would remove the unnecessary cast to default constraints sets and still offer the flexibility to add additional constraints sets params.
see #3698 and #3311