feat: add env debug output to oscommand#18
Open
matt-FFFFFF wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the debug logging within the OSCommand’s Run method to include environment variables, which can help with enhanced troubleshooting.
- Added "env" parameter to the debug log for command details.
- Updated the debug output in internal/runbatch/osCommand.go to include c.Env.
| With("label", fullLabel) | ||
|
|
||
| logger.Debug("command info", "path", c.Path, "cwd", c.Cwd, "args", c.Args) | ||
| logger.Debug("command info", "path", c.Path, "cwd", c.Cwd, "args", c.Args, "env", c.Env) |
There was a problem hiding this comment.
Consider filtering or redacting sensitive environment variable values from the debug log to avoid inadvertently exposing sensitive data.
Suggested change
| logger.Debug("command info", "path", c.Path, "cwd", c.Cwd, "args", c.Args, "env", c.Env) | |
| sanitizedEnv := sanitizeEnv(c.Env) | |
| logger.Debug("command info", "path", c.Path, "cwd", c.Cwd, "args", c.Args, "env", sanitizedEnv) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds environment to the debug output