test(runbatch): add unit tests for InheritEnv#40
Open
matt-FFFFFF wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the InheritEnv method in BaseCommand, which is responsible for merging parent environment variables into child commands without overwriting existing child values.
Key changes:
- Added 6 test cases covering empty maps, nil maps, non-overlapping keys, and overlapping keys with proper child precedence
- Tests follow the table-driven pattern consistent with existing tests in the file
- Tests verify that child environment variables take precedence over parent values when keys overlap
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-FFFFFF/porch into test/inherit-env-unit-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the InheritEnv method in BaseCommand to cover edge cases like empty maps, nil maps, and overlapping keys.