Fix broken build #12
Merged
Fix broken build #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
preview
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes dependency issues in the GitHub Actions workflow where version information was not being properly passed to subsequent publishing steps. The changes ensure that the generate-version job output is available to all publishing jobs that need the version number.
- Updated job dependencies to include
generate-versionin the needs array for publishing jobs - Enhanced step naming to include version information for better clarity
- Removed unnecessary build flags to simplify the build process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/reusable-publish.yml | Enhanced step naming and simplified build command |
| .github/workflows/ci.yml | Fixed job dependencies to ensure version outputs are available |
matt-goldman
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous workflow did not pass version number to subsequent steps
🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes