Fix plugin loading dependencies #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fail (for the issue that needs resolving)
github-actions
bot
added
the
preview
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes plugin loading dependencies by correcting test assertions and adds CI validation. The changes ensure plugin tests properly validate functionality and introduce automated testing on pull requests.
- Corrected Assert.Contains usage to use lambda expressions instead of incorrect overloads
- Added logging to test plugin for better debugging visibility
- Added GitHub Actions workflow for automated PR testing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 15 comments.
| File | Description |
|---|---|
tests/Blake.IntegrationTests/Commands/BlakePluginTests.cs |
Fixed test assertions using proper Assert.Contains syntax with lambda expressions |
tests/Blake.IntegrationTests/TestPluginWithDependencies/TestPluginWithDependencies.cs |
Added structured logging for better test debugging |
.github/workflows/pr-tests.yml |
Added new CI workflow to run tests on pull requests |
Added space before closing bracket in <TipContainer> tag and improved readability of the ChildContent property.
Implement functionality to initialize a Blazor app in `BlakeServeCommandTests.cs`. This includes handling the initialization of a project with a specified `.csproj` file, error handling for initialization failures, and the use of a cancellation token for command execution.
Enhance Razor template in BlakeServeCommandTests.cs by including the @using OptionsTest.Components directive, allowing access to additional components for improved functionality.
This commit introduces a `CancellationToken` parameter to various asynchronous methods across multiple files, enhancing control over task cancellation and improving responsiveness. Key updates include: - `InitProjectFile` in `ProjectFileBuilder.cs` now supports cancellation for file operations. - Similar updates in `SampleContentBuilder.cs`, `SiteGenerator.cs`, and `TemplateService.cs` for long-running tasks. - Logging statements have been modified to ensure consistent logging without null checks on the logger. - The main execution flow in `Program.cs` has been updated to manage cancellation tokens, allowing for graceful shutdowns. These changes collectively improve the application's resource management and logging consistency.
github-actions
bot
added
enhancement
Updated `Program.cs` to log the target path for baking the Blake site, improving traceability. Replaced instances of `RunBlakeFromDotnetAsync` with `RunBlakeCommandAsync` in `BlakeServeCommandTests.cs` for better argument handling. Adjusted test assertions to match the new logging format, enhancing clarity and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Intent of this PR was to ensure all plugin tests were configured correctly, in order to isolate and resolve the issue with loading dependencies of plugin projects. However fixing the assertions in the tests has verified this is working as expected.
PR now includes all tests passing, and adds a PR-test workflow.
🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes