Refactor folder retrieval logic to improve clarity and maintainability #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
preview
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors folder retrieval logic in the SiteGenerator class to eliminate code duplication and improve maintainability. The changes extract repeated folder filtering logic into a centralized method.
Key Changes:
- Extracted duplicated folder filtering logic into a new
GetAllFoldersmethod - Added additional folder exclusions (
wwwroot,node_modules) to the filtering criteria - Made the logger parameter non-nullable in
MapTemplatesmethod
Co-authored-by: Copilot <[email protected]>
matt-goldman
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45
🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes