Synchronize set_strategy with the discharge/load infrastructure#556
Open
herbelin wants to merge 1 commit intomattam82:mainfrom
Open
Synchronize set_strategy with the discharge/load infrastructure#556herbelin wants to merge 1 commit intomattam82:mainfrom
herbelin wants to merge 1 commit intomattam82:mainfrom
Conversation
Contributor
Author
|
As far as I can judge, this PR seems to really fix a bug: the opaque status of |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To register the opacity of lemmas generated by equations, the current code, except for issue #83, directly calls
Safe_typing.set_strategy. This PR synchronizes the occurrences ofSafe_typing.set_strategycorresponding to the registration of a constant with the discharge/load mechanism, and, suspectingly, this would solve other issues similar to #83 for other kinds of registered lemmas.Additionally, the PR would be necessary to eventually go in the direction of PR rocq-prover/rocq#17888 (discharge on the fly).
If I'm correct, that's the occurrences in
noconf_hom.ml,equations.ml, andprinciples.ml, but not the ones inprinciples_proofs.mlAs for the first
Safe_typing.set_strategyinprinciples.mlused in theinOpacityobject, I believe that theEQUATIONS_OPACITYobject can directly be replaced by Coq'sSTRATEGYobject which already plays the same purpose.