Add Service Discovery permissions and terminator for ecs_service#330
Open
jonpspri wants to merge 2 commits intomattclay:mainfrom
Open
Add Service Discovery permissions and terminator for ecs_service#330jonpspri wants to merge 2 commits intomattclay:mainfrom
jonpspri wants to merge 2 commits intomattclay:mainfrom
Conversation
jonpspri
force-pushed
the
ecs_service
branch
from
c4cb20c to
2ce327a
Compare
There was a problem hiding this comment.
Pull request overview
Adds AWS Cloud Map (Service Discovery) support needed for ecs_service Service Connect integration tests by expanding IAM policies and adding a cleanup terminator for stale HTTP namespaces.
Changes:
- Extend
networkingIAM policy withservicediscoverypermissions required for Cloud Map HTTP namespace operations. - Extend
paasIAM policy to allow creation of the ELB service-linked role. - Add a new terminator to discover and delete stale Cloud Map HTTP namespaces.
- Update
aws/config.ymlaccount IDs and region (appears unrelated to the stated PR scope).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
aws/terminator/networking.py |
Adds ServiceDiscoveryHttpNamespace terminator to list/delete stale HTTP namespaces. |
aws/policy/paas.yaml |
Grants iam:CreateServiceLinkedRole for ELB service-linked role creation. |
aws/policy/networking.yaml |
Adds servicediscovery permissions for Cloud Map HTTP namespace support. |
aws/config.yml |
Changes lambda/access/test account IDs and AWS region (not mentioned in PR description). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 12, 2026
Open
jonpspri
force-pushed
the
ecs_service
branch
from
8b3d99e to
f2511b5
Compare
Add IAM permissions and terminator class to support ecs_service Service Connect integration tests: - Add servicediscovery permissions (CreateHttpNamespace, DeleteNamespace, GetOperation, ListNamespaces) to networking policy - Add ELB service-linked role creation permission to paas policy - Add ServiceDiscoveryHttpNamespace terminator class for cleanup of HTTP namespaces created during integration tests Expand Service Discovery support for all namespace types Generalize the terminator from HTTP-only to all namespace types (HTTP, DNS_PUBLIC, DNS_PRIVATE) and delete child services before deleting namespaces. Add corresponding IAM permissions. Extract ECS task definition cleanup into its own terminator class Move task definition lifecycle management out of Ecs.terminate() into a new EcsTaskDefinition(DbTerminator) class. This fixes the blast radius issue where cleaning up any stale cluster would deregister all task definitions in the account. Task definitions are now independently tracked and aged via DynamoDB. Also adds ecs:DeleteTaskDefinitions to the paas policy and fully deletes (not just deregisters) stale task definitions. Subsumes PR mattclay#331. Split ECS policy into separate paas-ecs policy file
jonpspri
force-pushed
the
ecs_service
branch
2 times, most recently
from
0f514d0 to
9c6ecb5
Compare
gravesm
reviewed
Feb 17, 2026
jonpspri
force-pushed
the
ecs_service
branch
from
8190b1d to
a69b108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servicediscoveryIAM permissions to support all namespace types (HTTP, Public DNS, Private DNS) along withGetNamespace,ListServices, andTagResourceServiceDiscoveryNamespaceterminator to clean up all namespace types, including deleting child services before namespace removalContext
These changes support the
ecs_serviceandcloudmapintegration tests in community.aws:Test plan