fix: verification endpoint alignment with etherscan#367
Open
kiriyaga-txfusion wants to merge 4 commits intomainfrom
Open
fix: verification endpoint alignment with etherscan#367kiriyaga-txfusion wants to merge 4 commits intomainfrom
kiriyaga-txfusion wants to merge 4 commits intomainfrom
Conversation
API E2E Test Results207 tests 207 ✅ 20s ⏱️ Results for commit 3ca1ce0. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 265 suites 12m 3s ⏱️ Results for commit 3ca1ce0. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
Romsters
reviewed
Jan 16, 2025
| ].includes(request.codeformat); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const semver = require("semver"); |
Contributor
Author
There was a problem hiding this comment.
Import doesn't work because the semver package only functions with CommonJS modules. I found a workaround using require to properly use the object.
Contributor
Author
There was a problem hiding this comment.
I tried with semver and its type, but the dependency object is always null.
Romsters
reviewed
Jan 16, 2025
packages/api/src/api/dtos/contract/verifyContractRequest.dto.ts
Outdated
Show resolved
Hide resolved
popzxc
reviewed
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Resolved incompatibilities with the explorer's verification API endpoint.
Why ❔
For contract verification through Foundry and Hardhat, the API endpoint should function in the same way as it works on Etherscan.
fixes #351
Checklist