Skip to content

fix(EVM): EVM emulator fixes after the audit#1134

Merged
0xVolosnikov merged 63 commits intostable/evm-emulatorfrom
evm-emulator/fixes
Jan 16, 2025
Merged

fix(EVM): EVM emulator fixes after the audit#1134
0xVolosnikov merged 63 commits intostable/evm-emulatorfrom
evm-emulator/fixes

Conversation

@0xVolosnikov
Copy link
Contributor

@0xVolosnikov 0xVolosnikov commented Dec 6, 2024

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@0xVolosnikov 0xVolosnikov force-pushed the evm-emulator/fixes branch 2 times, most recently from 48a3aa9 to 286a4dc Compare December 10, 2024 15:34
0xVolosnikov and others added 28 commits December 10, 2024 17:23
@0xVolosnikov
fix(EVM): Add static MCOPY cost (#1081)
44bd426
@0xVolosnikov
fix(EVM): Cleanup in checkMemIsAccessible (#1082)
8e8323d
@0xVolosnikov
fix(EVM): Simplify OP_PC (#1084)
ef91e52
@0xVolosnikov
fix(EVM): Do not charge additionally for EraVM decommit (#1086)
b649f5f
@0xVolosnikov
fix(EVM): Fix stack overflow check (#1085)
5db2a30
@0xVolosnikov
fix(EVM): Add stack overflow check in dup (#1087)
ba50e19
@0xVolosnikov
fix(EVM): Fix SSTORE warmth check (#1089)
30d56ad
@0xVolosnikov
fix(EVM): Fix CALL in static context (#1091)
6fe1257
@0xVolosnikov
fix(EVM): Fix calls to contract being created (#1093)
1818626
@0xVolosnikov
fix(EVM): Wrap access to calldata to prevent out-of-bounds EraVM panic (
12efa1c 
#1097)
@0xVolosnikov
fix(EVM): Zero out frame gas left for underpaid precompiles (#1101)
07f43d0
@0xVolosnikov
fix(EVM): Fix panics on insufficient balance in calls (#1108)
c74c6ec
@0xVolosnikov
fix(EVM): Fix DUP1 underflow check (#1110)
5869331
@0xVolosnikov @vladimirradosavljevic
fix(EVM): Update LLVM options after fixes (#1112)
55367f5 
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Co-authored-by: Vladimir Radosavljevic <vr@matterlabs.dev>
@0xVolosnikov
fix(EVM): Do not check memory boundaries if size is zero (#1114)
70d1de8
@0xVolosnikov
fi(EVM): Fix EXTCODECOPY zeroing offset (#1115)
37874c7
@0xVolosnikov
fix(EVM): Cleanup address bytes in EXTCODECOPY (#1116)
6a76d76
@0xVolosnikov
fix(EVM): Use raw calls to precompiles (#1118)
2bdc565
@0xVolosnikov
fix(EVM): Make DELEGATECALL behavior closer to EVM (3) (#1120)
3299faa
@0xVolosnikov
fix(EVM): Handle corner case of KECCAK with 0 size (#1121)
483b099
@0xVolosnikov
fix(EVM): Make fetchDeployedCode more robust (2) (#1123)
d61e38d
@0xVolosnikov
fix(EVM): Increase max allowed memory (2) (#1124)
47b2ddd
@0xVolosnikov
fix(EVM): Implement EXTCODEHASH in emulator (#1125)
c4c964b
@0xVolosnikov
fix(EVM): Add stipends for calls to zkVM contracts (#1126)
921b3e3
@0xVolosnikov
fix(EVM): Make CREATE flow equivalent to EVM (#1127)
ef80122
@0xVolosnikov
Handle Empty.sol as empty account
b61406b
@0xVolosnikov
Do not call precompiles if not enough gas provided
72bbed0
@0xVolosnikov
fix(EVM): Fix logs implementation (2) (#1137)
daf7022
0xVolosnikov and others added 24 commits December 30, 2024 17:36
@0xVolosnikov
fix(EVM): Fix misleading comment (N-03) (#1170)
ba441ac
@0xVolosnikov
fix(EVM): Gas optimizations (N-04) (#1171)
2947cab
@0xVolosnikov
fix(EVM): Remove deadcode (N-06) (#1172)
20bcb74
@0xVolosnikov
fix(EVM): Simplify set constructing bytecode hash (N-07) (#1173)
ad62263
@0xVolosnikov
fix(EVM): Code simplification (N-05) (#1174)
ddea0fc
@0xVolosnikov
fix(EVM): Remove magic numbers (N-09) (#1175)
816c358
@0xVolosnikov
fix(EVM): Add missing documentation (N-10) (#1176)
bfc691f
@0xVolosnikov
fix(EVM): Remove redundant warming of EVM account during construction…
26df944 
… (N-12) (#1177)
@0xVolosnikov
fix(EVM): Use constant PREVRANDAO value (N-11) (#1178)
b494799
@0xVolosnikov
fix(EVM): Add functionality for force EVM deploys (L-04) (#1179)
e3307c3
@0xVolosnikov
fix(EVM): Fix cross vm panic returndata logic (L-03) (#1180)
66c8e51
@0xVolosnikov
fix(EVM): Check the bytecode length on call (L-05) (#1181)
969886c
@0xVolosnikov
fix(EVM): Check bytecodehash version in create functions of ContractD…
b194c86 
…eployer (#1182)
@0xVolosnikov
fix(EVM): Simplify ContractDeployer storage layout (#1143)
a539040
@0xVolosnikov
fix(EVM): Small misc fixes (#1184)
0ac215c
@0xVolosnikov
chore(EVM): Update hashes (#1185)
600d20a
@0xVolosnikov
fix(EVM): Change additional stipends for calls to empty contracts (M-…
3c77d4a 
…03) (#1194)
@0xVolosnikov
fix(EVM): Simplify padding (H-05) (#1195)
875d0a5
@0xVolosnikov
fix(EVM): Increment nonce after EVM force deploy (L-04) (#1197)
0d6fec7
@0xVolosnikov
fix(EVM): Use stricter checks for calldata (M-06, M-07) (#1200)
16b76a2
@0xVolosnikov
Add comments for delegate call implementation (L-10)
0e0a7ac
@0xVolosnikov
Apply suggested change
a9eb273
@0xVolosnikov
Charge additional 32k gas in contract creation from EOA or EraVM cont…
bbfd8e7 
…ract (N-13)
@0xVolosnikov
Merge pull request #1196 from matter-labs/evm-emulator/additional-fix…
564b44d 
…es-after-review

fix(EVM): Additional fixes after review
@0xVolosnikov 0xVolosnikov marked this pull request as ready for review January 15, 2025 13:46
@0xVolosnikov 0xVolosnikov merged commit 964c78a into stable/evm-emulator Jan 16, 2025
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deniallugo Deniallugo Awaiting requested review from Deniallugo Deniallugo is a code owner

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok is a code owner

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@0xVolosnikov