Display more deployed addresses#1203
Merged
StanislavBreadless merged 16 commits intorelease-v26from Jan 23, 2025
Merged
Conversation
StanislavBreadless
changed the base branch from
sync-layer-stable
to
release-v26
…es' into sb-display-more-deployed-addresses
| "evmBytecodeHash": "0x534bc5e7432735c8808d91708e9eab901f55a7ec6f7c0f878bb562757b6a99d9", | ||
| "evmBytecodePath": "/l1-contracts/out/Utils.sol/Utils.json", | ||
| "evmDeployedBytecodeHash": "0x43081c39edfbf9f44a8f1c1f0e5e00423e727da0da196eab876aed9949811e77" | ||
| "evmBytecodeHash": "0x4c9033aa9f834d00d4110549c502fecc1028b31b071c5d4833f1e23a59c941bf", |
Collaborator
Author
There was a problem hiding this comment.
this one changed because previously for the l1-contracts/Utils we used /l1-contracts/out/Utils.sol/Utils.json, while now we are using /l1-contracts/out/SystemContractsCaller.sol/Utils.json. The former was from a test, while the latter is actually a library in code
mm-zk
approved these changes
Jan 20, 2025
| securityCouncilDigest = EIP712Utils.buildDomainHash(securityCouncilAddr, "SecurityCouncil", "1"); | ||
| } | ||
|
|
||
| bytes[] memory securityCouncilRawSignatures = new bytes[](12); |
Collaborator
There was a problem hiding this comment.
comment why 12 - and maybe do a constant?
| } | ||
| } | ||
|
|
||
| function securityCouncilApproveUpgrade( |
Collaborator
There was a problem hiding this comment.
add a comment on what this method does
| safeDigest = ISafe(securityCouncilMembers[i]).getMessageHash(abi.encode(digest)); | ||
| } | ||
| { | ||
| (uint8 v, bytes32 r, bytes32 s) = vm.sign(_governorWallet, safeDigest); |
Collaborator
There was a problem hiding this comment.
so we're using governor's wallet 12 times ?
Collaborator
Author
There was a problem hiding this comment.
yes, this is the case for the staging env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Note, that I changed ValidatorTimelock constructor params to better correspond to those in the Solidity file. The previous one worked because Solidity ignores any additional bytes after the main constructor params
Why ❔
Checklist