Skip to content

feat: v29 #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 270 commits into
base: draft-v28
Choose a base branch
from
Open

feat: v29 #1419

wants to merge 270 commits into from

Conversation

kelemeno
Copy link
Contributor

@kelemeno kelemeno commented Apr 17, 2025

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

Coverage after merging draft-v29 into draft-v28 will be

83.79%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   BridgeHelper.sol85%100%100%84.21%31, 36, 41
   BridgedStandardERC20.sol80.28%100%92.31%77.59%120–121, 126–127, 139–140, 164, 205, 212, 219, 230, 63, 91
   L1ERC20Bridge.sol92.86%100%100%91.43%189, 208, 270
   L1Nullifier.sol82.89%100%86.21%82.28%114, 129–130, 160, 221, 224, 234, 237, 247, 250, 418–420, 424–425, 452, 518, 602, 614, 652, 654, 710, 713, 715, 728, 742, 747, 767
contracts/bridge/asset-router
   AssetRouterBase.sol94.44%100%100%92.86%59, 87
   L1AssetRouter.sol88.82%100%88.89%88.80%208, 246, 262, 360, 391, 430–431, 445, 548, 60, 648, 667, 76, 84
contracts/bridge/interfaces
   AssetHandlerModifiers.sol66.67%100%100%50%13
contracts/bridge/ntv
   L1NativeTokenVault.sol84.78%100%87.50%84.21%144–150, 152, 220–221, 223, 236
   NativeTokenVault.sol89.10%100%92%88.55%102, 234, 239, 256, 274, 279, 295, 314, 322, 488, 503, 531, 565, 570, 74
contracts/bridgehub
   Bridgehub.sol83.77%100%86.67%83.18%115, 123, 129–130, 137, 166, 182, 229, 232, 241, 251, 264, 279, 308, 332, 335, 395, 411, 442, 522, 604, 702, 706, 710–711, 730, 733, 784, 787, 790, 825, 829, 832, 867, 872, 881, 886
   CTMDeploymentTracker.sol75%100%90%69.23%101, 126, 131, 32, 40, 63, 93, 97
   ChainAssetHandler.sol78.18%100%77.78%78.26%120, 134, 137, 187, 236, 241, 54, 60–61, 68
   L2MessageVerification.sol100%100%100%100%
   MessageRoot.sol95%100%100%93.75%121, 170, 97
contracts/common
   ReentrancyGuard.sol94.12%100%100%92.86%79
contracts/common/l2-helpers
   L2ContractHelper.sol82.22%100%100%78.38%102, 108, 112, 129, 134, 73, 79, 83
   SystemContractsCaller.sol0%100%0%0%114, 122–125, 135–139, 141–142, 33–34, 37, 45, 47, 49, 51, 53, 66, 69, 72, 75, 78, 89, 91, 93, 96, 98
contracts/common/libraries
   DataEncoding.sol86.11%100%100%81.48%110, 118, 163, 177, 45
   DynamicIncrementalMerkle.sol73.17%100%80%72.22%67–70, 72–74, 76–78
   FullMerkle.sol100%100%100%100%
   Merkle.sol97.96%100%100%97.73%83
   MessageHashing.sol94.44%100%100%93.75%113, 77, 94
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   AccessControlRestriction.sol100%100%100%100%
   ChainAdmin.sol97.30%100%100%96.30%39
   ChainAdminOwnable.sol45.83%100%40%47.37%28, 39–40, 47–48, 57, 66, 78–79, 81
   Governance.sol100%100%100%100%
   L2ProxyAdminDeployer.sol0%100%0%0%17–18, 20
   PermanentRestriction.sol87.39%100%100%85.57%103, 110–111, 199–200, 203–204, 207, 209–210, 239, 287, 309, 340
   ServerNotifier.sol90.91%100%100%86.67%55, 65
   TransitionaryOwner.sol0%100%0%0%17, 22–23
contracts/governance/restriction
   Restriction.sol100%100%100%100%
   RestrictionValidator.sol100%100%100%100%
contracts/state-transition
   ChainTypeManager.sol91.61%100%94.59%90.68%106, 250–252, 267, 396, 458, 486, 493, 520, 568
   ValidatorTimelock.sol94.64%100%100%93.02%187, 202, 79
contracts/state-transition/chain-deps
   DiamondInit.sol92.50%100%100%92.11%50, 54, 58
   DiamondProxy.sol100%100%100%100%
   GatewayCTMDeployer.sol0%100%0%0%165, 170–172, 174, 176, 178, 186, 188–189, 191, 193, 195–197, 203, 223, 226–227, 229, 235, 239–240, 253–255, 263–265, 284–289, 293, 312, 314, 316–317, 321, 323–325, 338, 342–343, 349, 355, 361, 368, 378, 384, 386, 396, 404, 423, 427, 440, 445
contracts/state-transition/chain-deps/facets
   Admin.sol80.93%100%88%79.88%151, 168, 171, 175, 183–184, 187, 189, 192, 197, 201, 297, 300, 308, 315, 335, 348, 351, 358, 371, 374–375, 377–378, 380–381, 383, 386, 417, 421, 432, 445, 451, 48
   Executor.sol88.28%100%100%86.90%132, 156, 194, 243, 252, 255, 259, 289, 361, 415, 433, 455–457, 460, 462, 464–465, 467, 490–491, 509, 51, 525–526, 587, 592, 618, 679, 706
   Getters.sol88.89%100%87.50%89.86%114, 134, 172, 242, 247, 251, 69
   Mailbox.sol92.54%100%95.83%91.82%185, 191, 198, 257,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants