Skip to content

feat: create more detailed verification logs #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: draft-v28
Choose a base branch
from
Open

feat: create more detailed verification logs #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion l1-contracts/deploy-scripts/Create2FactoryUtils.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,12 @@ abstract contract Create2FactoryUtils is Script {
}

if (isZKBytecode) {
forgeMessage = string.concat(forgeMessage, " --verifier zksync");
forgeMessage = string.concat(forgeMessage, " --zksync --verifier zksync");
} else {
forgeMessage = string.concat(
forgeMessage,
" --chain=sepolia (only for testnet verification, omit for mainnet)"
);
}
console.log(forgeMessage);
}
Expand All @@ -227,6 +232,19 @@ abstract contract Create2FactoryUtils is Script {
function getDeployedContractName(string memory contractName) internal view virtual returns (string memory) {
if (compareStrings(contractName, "BridgedTokenBeacon")) {
return "UpgradeableBeacon";
} else if (compareStrings(contractName, "VerifierFflonk")) {
return "L1VerifierFflonk";
} else if (compareStrings(contractName, "VerifierPlonk")) {
return "L1VerifierPlonk";
} else if (compareStrings(contractName, "Verifier")) {
return "DualVerifier (TestnetVerifier for non-mainnet deployments)";
} else if (compareStrings(contractName, "MailboxFacet")) {
return "./contracts/state-transition/chain-deps/facets/Mailbox:MailboxFacet";
} else if (compareStrings(contractName, "Bridgehub")) {
return
"Bridgehub (ensure it is compiled with forge build --optimizer-runs 28000 contracts/bridgehub/Bridgehub.sol)";
} else if (compareStrings(contractName, "BlobVersionedHashRetriever")) {
return "!!! BlobVersionedHashRetriever verification can be skipped as it wasn't compiled with sol !!!)";
} else {
return contractName;
}
Expand Down
Loading